Review Request 118619: Sort by filename, which is RemoteId, instead of item id to make ItemFetchJob test pass

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118619/#review59571
-----------------------------------------------------------

Ship it!


It's a suggestion by Kevin Krammer and fixes the test, don't think it needs more reason than that to be commited.

- Albert Astals Cid


On June 8, 2014, 4:45 p.m., Martin Steigerwald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118619/
> -----------------------------------------------------------
> 
> (Updated June 8, 2014, 4:45 p.m.)
> 
> 
> Review request for KDEPIM, KDEPIM-Libraries, Albert Astals Cid, Dan Vrátil, and Sergio Luis Martins.
> 
> 
> Bugs: 334218
>     http://bugs.kde.org/show_bug.cgi?id=334218
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> Sort by filename, which is RemoteId, instead of item id to make test pass.
>     
> Review request 118441 introduced sorting of items for ItemFetchJob
> testcase as due to an performance optimization mixedmaildir resource
> does not sort anymore. This fixed the testcase for me on BTRFS.
>     
> However on the Jenkins server the test case was still not fixed and
> Kevin pointed out that qSort may sort by item id instead of RemoteId.
> The test relies on sorting by filename, which is basically the RemoteId.
>     
> With the change the test still passes on my BTRFS setup. Yet once
> mixedmaildir-storecompacttest test failed. On subsequent runs of
> "make test" this didn´t happen again.
> 
> This needs to go into KDE SC 4.13.2 to have all test cases of
> kdepim-runtime pass.
> 
> 
> Diffs
> -----
> 
>   resources/mixedmaildir/tests/itemfetchtest.cpp fe034beb396e28b40ef732fb7468ea2b173d9460 
> 
> Diff: https://git.reviewboard.kde.org/r/118619/diff/
> 
> 
> Testing
> -------
> 
> make test after building with the change.
> 
> 
> Thanks,
> 
> Martin Steigerwald
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20140608/417bfc30/attachment.html>