[Kde-pim] Review Request 118608: Review for API - mail composer class

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118608/#review59570
-----------------------------------------------------------



mobile/api/mail/compose.h
<https://git.reviewboard.kde.org/r/118608/#comment41520>

    GNU Library General Public License
    see, e.g. mobile/mail/mainview.h



mobile/api/mail/compose.h
<https://git.reviewboard.kde.org/r/118608/#comment41519>

    Compose -> Composer
    



mobile/api/mail/compose.h
<https://git.reviewboard.kde.org/r/118608/#comment41521>

    Using the same change signal is technically possible, but not always good.
    The change signal will trigger QML binding updates, i.e. right now any change in for example subject would require QML updates to all five properties.
    
    I would recommend separate change signals unless two properties are likely to change together



mobile/api/mail/compose.cpp
<https://git.reviewboard.kde.org/r/118608/#comment41522>

    check of whether there is a change and if there is emit change signal.
    See previous revision's comments


- Kevin Krammer


On June 8, 2014, 3:32 p.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118608/
> -----------------------------------------------------------
> 
> (Updated June 8, 2014, 3:32 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Api for Creating the text Mail. I have also added the function for sending the mail. Sending the mail part is yet to be tested.
> 
> 
> Diffs
> -----
> 
>   mobile/api/mail/compose.h PRE-CREATION 
>   mobile/api/mail/compose.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118608/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/