[Kde-pim] Review Request 118609: Changes made in the API folder - CMAKELISTS.txt and others

[Kevin Krammer]

> On June 8, 2014, 8:02 a.m., Michael Bohlender wrote:
> > mobile/api/mail/CMakeLists.txt, line 14
> > <https://git.reviewboard.kde.org/r/118609/diff/1/?file=279586#file279586line14>
> >
> >     is it really nessesary to include all of these? please only include what is needed for the moment. so we can keep a clean cmakelist.txt
> 
> Abhijeet Nikam wrote:
>     Yes, else I have to include "messagecomposer/ " in the headers. for eg. instead of simply using "recipient/..." , I have to include "messagecomposer/recipient" in the header files for it to compile. It didn't occur after I added it, I'll change the others to include what is required for now.

KMail does this as well, so it seems to be the canonical way to use these libraries


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118609/#review59537
-----------------------------------------------------------


On June 8, 2014, 8:24 a.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118609/
> -----------------------------------------------------------
> 
> (Updated June 8, 2014, 8:24 a.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> I could not manage the patches in same diff. I have added the required things in cmakelist.txt (like linked libraries etc) which may be needed in future and made some neccessary changes in the mail plugin (register the class).
> 
> 
> Diffs
> -----
> 
>   mobile/api/mail/CMakeLists.txt ef1c3ff 
>   mobile/api/mail/folderlist.h 06f92f2 
>   mobile/api/mail/mailplugin.cpp 42f0df7 
> 
> Diff: https://git.reviewboard.kde.org/r/118609/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/