[Kde-pim] Review Request 118663: Outline of the receiver model
Abhijeet Nikam
connect08nikam at gmail.com
Sat Jun 28 21:49:38 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118663/
-----------------------------------------------------------
(Updated June 28, 2014, 8:49 p.m.)
Review request for KDEPIM, Kevin Krammer and Michael Bohlender.
Changes
-------
Finally works so well after removing the if statement - thanks Michael :)
Tested it by creating the objects and using ListView { ... }, in the same manner as in previous review.
But Kevin, any idea why didn't it work before - the if statement in data()? if ( role == Qt::DisplayRole || role == Qt::EditRole )? I tried both, but they don't work.
Will add the receiver model to the composer in the next patch. Thanks.
Repository: kdepim
Description
-------
These is the basic outline of my receiver model, I wanted to have a review of this before further implementing the .cpp file.
Diffs (updated)
-----
mobile/api/mail/CMakeLists.txt ea2de75
mobile/api/mail/mailplugin.cpp bf1bf40
mobile/api/mail/receivermodel.h PRE-CREATION
mobile/api/mail/receivermodel.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/118663/diff/
Testing
-------
Compiles without any errors.
Thanks,
Abhijeet Nikam
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list