Review Request 118400: Manually sort the QStringList for the readEntryFlags test

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118400/#review59487
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Krammer


On June 7, 2014, 7:38 a.m., Martin Steigerwald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118400/
> -----------------------------------------------------------
> 
> (Updated June 7, 2014, 7:38 a.m.)
> 
> 
> Review request for KDEPIM, KDEPIM-Libraries, Dan Vrátil, and Sergio Luis Martins.
> 
> 
> Bugs: 334218
>     http://bugs.kde.org/show_bug.cgi?id=334218
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> Manually sort the QStringList for the readEntryFlags test
>     
> Otherwise the individual test in this testcase may work on the wrong
> mails as libmaildir doesn´t sort the entry list anymore.
> 
> This is related to the nosorting change from review request 117975.
> 
> This needs to go into 4.13 branch as well before release of 4.13.2.
> 
> 
> Diffs
> -----
> 
>   resources/maildir/libmaildir/tests/testmaildir.cpp 47bc5c99dda020c35ef94c7f319edf2e12e4bf17 
> 
> Diff: https://git.reviewboard.kde.org/r/118400/diff/
> 
> 
> Testing
> -------
> 
> The test FlagsReading passes with the fix applied:
> 
> martin at merkaba:~/KDE/Dev/kdepim-runtime/build/resources/maildir/libmaildir/tests> ./testmaildir
> ********* Start testing of MaildirTest *********
> Config: Using QTest library 4.8.6, Qt 4.8.6
> PASS   : MaildirTest::initTestCase()
> PASS   : MaildirTest::testMaildirInstantiation()
> PASS   : MaildirTest::testMaildirCreation()
> PASS   : MaildirTest::testMaildirListing()
> PASS   : MaildirTest::testMaildirAccess()
> PASS   : MaildirTest::testMaildirReadHeaders()
> PASS   : MaildirTest::testMaildirWrite()
> PASS   : MaildirTest::testMaildirAppend()
> QWARN  : MaildirTest::testMaildirRemoveEntry() Maildir::readEntry unable to find:  "1401378906.R958.merkaba" 
> PASS   : MaildirTest::testMaildirRemoveEntry()
> PASS   : MaildirTest::testMaildirListSubfolders()
> PASS   : MaildirTest::testMaildirCreateSubfolder()
> PASS   : MaildirTest::testMaildirRemoveSubfolder()
> PASS   : MaildirTest::testMaildirRename()
> PASS   : MaildirTest::testMaildirMoveTo()
> PASS   : MaildirTest::testMaildirFlagsReading()
> PASS   : MaildirTest::testMaildirFlagsWriting()
> PASS   : MaildirTest::cleanupTestCase()
> Totals: 17 passed, 0 failed, 0 skipped
> ********* Finished testing of MaildirTest *********
> 
> I don´t know about the testMaildirRemoveEntry. Maybe there is also some issue with the sorting...
> 
> 
> Thanks,
> 
> Martin Steigerwald
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20140607/56a9a2cd/attachment.html>