[Kde-pim] Review Request 118903: [Blogilo] Replace GData backend with new Blogger backend

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118903/#review60839
-----------------------------------------------------------



blogilo/src/bilboblog.cpp
<https://git.reviewboard.kde.org/r/118903/#comment42395>

    I know "break;" is not necessary but better to add it.



blogilo/src/dbman.cpp
<https://git.reviewboard.kde.org/r/118903/#comment42396>

    I prefer to store authData.constEnd(); outside for loop
    => QMap<QString,QString> endIter = authData.constEnd();
    for (....; iter != endIter; ++iter) {
    ...
    }


- Laurent Montel


On June 23, 2014, 4:17 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118903/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 4:17 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> (Note: this review needs https://git.reviewboard.kde.org/r/118902/ to be approved and committed first)
> 
> This patch replaces use of GData backend in Blogilo by the new Blogger backend, which is using the latest Google API for Blogger (blogspot.com) service (https://developers.google.com/blogger/docs/3.0/reference/).
> 
> The main difference is that Blogger is using OAuth, so this patch adds a new DB table to store the OAuth tokens in there, from where they can be retrieved on demand. For this I also introduced a very simple database schema versioning/updating mechanism.
> 
> 
> Diffs
> -----
> 
>   blogilo/src/addeditblog.h 63b2658 
>   blogilo/src/addeditblog.cpp f90deb6 
>   blogilo/src/backend.h 0277811 
>   blogilo/src/backend.cpp b5d68a6 
>   blogilo/src/bilboblog.h d661eb7 
>   blogilo/src/bilboblog.cpp 7f79ff0 
>   blogilo/src/dbman.h e456d3d 
>   blogilo/src/dbman.cpp 23d2827 
> 
> Diff: https://git.reviewboard.kde.org/r/118903/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/