[Kde-pim] Review Request 118608: Review for API - mail composer class

[Abhijeet Nikam]

> On June 8, 2014, 9:27 p.m., Kevin Krammer wrote:
> > mobile/api/mail/composer.cpp, line 56
> > <https://git.reviewboard.kde.org/r/118608/diff/3/?file=279759#file279759line56>
> >
> >     almost right :)
> >     currently it is always emitted, evevn then the value does not actually change
> 
> Abhijeet Nikam wrote:
>     Should I make from too as QStringList? For multiple senders?
> 
> Kevin Krammer wrote:
>     No, I don't think that this would make sense.
>     In the end this is most likely going to be a configured email identity or derived from one and I don't think identities can have multiple "sender" addresses

Yes, That is what I thought, but Jan questioned about multiple senders so I asked. Anyway, thanks for the reviews :)


- Abhijeet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118608/#review59582
-----------------------------------------------------------


On June 8, 2014, 10:12 p.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118608/
> -----------------------------------------------------------
> 
> (Updated June 8, 2014, 10:12 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Api for Creating the text Mail. I have also added the function for sending the mail. Sending the mail part is yet to be tested.
> 
> 
> Diffs
> -----
> 
>   mobile/api/mail/CMakeLists.txt ef1c3ff 
>   mobile/api/mail/composer.h PRE-CREATION 
>   mobile/api/mail/composer.cpp PRE-CREATION 
>   mobile/api/mail/folderlist.h 06f92f2 
>   mobile/api/mail/mailplugin.cpp 42f0df7 
> 
> Diff: https://git.reviewboard.kde.org/r/118608/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/