[Kde-pim] Review Request 118496: Use credentials in the "Edit Host" window to query LDAP Server.

[Laurent Montel]

> On June 3, 2014, 12:25 p.m., Laurent Montel wrote:
> > kldap/ldapserver.cpp, line 373
> > <https://git.reviewboard.kde.org/r/118496/diff/1/?file=278260#file278260line373>
> >
> >     not else now ?
> 
> Sandro Knauß wrote:
>     There are only three different authentification options:
>     SASL, Simple and Anonymous
>     Anonymous auth is defined as login without user or password, otherwise it is Simple Auth.

ok so it was broken before.
ok


> On June 3, 2014, 12:25 p.m., Laurent Montel wrote:
> > kldap/ldapconfigwidget.cpp, line 345
> > <https://git.reviewboard.kde.org/r/118496/diff/1/?file=278259#file278259line345>
> >
> >     Why removed this part ?
> 
> Sandro Knauß wrote:
>     This logic is inside the LdapServer::url method, that's why we don't need to have the settings by hand.

ok


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118496/#review59083
-----------------------------------------------------------


On June 3, 2014, 12:07 p.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118496/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 12:07 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Bugs: 335651
>     http://bugs.kde.org/show_bug.cgi?id=335651
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> If the server needs authentification to connect, the "Query Server"
> to get the namingcontexts should use the credentials.
> 
> 
> Diffs
> -----
> 
>   kldap/ldapconfigwidget.cpp 703adf2671fc7ed0a4ba92000d1408dbc623a887 
>   kldap/ldapserver.cpp 854c97ddba3a966c76580d644d9fed8116769237 
> 
> Diff: https://git.reviewboard.kde.org/r/118496/diff/
> 
> 
> Testing
> -------
> 
> Testing with a LDAP Server that support Simple Auth and get "Query Server" for DN successfully.
> 
> "supportedsaslmechanisms" should be working without credentions, otherwise queriing the server doesn't make sense.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/