[Kde-pim] Review Request 118663: Outline of the receiver model

Abhijeet Nikam connect08nikam at gmail.com
Wed Jun 25 08:14:11 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118663/
-----------------------------------------------------------

(Updated June 25, 2014, 7:14 a.m.)


Review request for KDEPIM, Kevin Krammer and Michael Bohlender.


Changes
-------

I have added a recipientString function in the Receiver Model, since we will be needing a string in the present send function code. For testing -> I created an objects in the constructor and  used 
ListView {
model : Mail.ReceiverModel {}
 delegate: Text {
        text: + name  + ": " + email   
}

But the ouput is  only undefined in place of name and email for those objects. Is something is wrong with definition of the roles?


Repository: kdepim


Description
-------

These is the basic outline of my receiver model, I wanted to have a review of this before further implementing the .cpp file.


Diffs (updated)
-----

  mobile/CMakeLists.txt aca765d 
  mobile/api/mail/CMakeLists.txt 27ab592 
  mobile/api/mail/composer.h 2dfa16a 
  mobile/api/mail/composer.cpp 20333d1 
  mobile/api/mail/mailplugin.cpp bf1bf40 
  mobile/api/mail/receivermodel.h PRE-CREATION 
  mobile/api/mail/receivermodel.cpp PRE-CREATION 
  mobile/api/mail/recipient.h PRE-CREATION 
  mobile/api/mail/recipient.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/118663/diff/


Testing
-------

Compiles without any errors.


Thanks,

Abhijeet Nikam

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list