[Kde-pim] Review Request 118902: Add support for Google Blogger V3 API to KBlog

Laurent Montel montel at kde.org
Mon Jun 30 07:14:05 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118902/#review61244
-----------------------------------------------------------



kblog/CMakeLists.txt
<https://git.reviewboard.kde.org/r/118902/#comment42647>

    not critical but you cab add:
    if (LibKGAPI2_FOUND)
       include_directories(${LibKGAPI2_INCLUDE_DIR})
    endif()
    



kblog/CMakeLists.txt
<https://git.reviewboard.kde.org/r/118902/#comment42648>

    same here:
    if (LIBKGAPI2_FOUND)
      target_link_libraries(kblog ${...})
    endif()



kblog/blogger.cpp
<https://git.reviewboard.kde.org/r/118902/#comment42649>

    QList<Blohpost>::Iterator end( posts.end());
    
    for (iter = posts.begin(); iter != end;...)
    


- Laurent Montel


On June 23, 2014, 4:10 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118902/
> -----------------------------------------------------------
> 
> (Updated June 23, 2014, 4:10 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Christian Weilbach.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> This patch adds support for Google's Blogger service (blogspot.com) using the native Blogger V3 API. This effectively obsoletes the current GData implementation.
> 
> The actual protocol implementation is available in LibKGAPI, a KDE library that implements various Google APIs.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7a1ea0d 
>   kblog/CMakeLists.txt 7c985db 
>   kblog/blogger.h PRE-CREATION 
>   kblog/blogger.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118902/diff/
> 
> 
> Testing
> -------
> 
> Tested with modified Blogilo, I was able to list, create, update and remove posts
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list