[Kde-pim] Review Request 118663: Outline of the receiver model

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118663/#review59998
-----------------------------------------------------------



mobile/api/mail/receivermodel.h
<https://git.reviewboard.kde.org/r/118663/#comment41772>

    Better keep the QAbstractListModel.
    table models are a but under supported in QtQuick, I think only QtQuick2 as of Qt5.2 onwards can deal with them



mobile/api/mail/receivermodel.h
<https://git.reviewboard.kde.org/r/118663/#comment41773>

    enum values should start with a capital letter


- Kevin Krammer


On June 13, 2014, 7:25 a.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118663/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 7:25 a.m.)
> 
> 
> Review request for KDEPIM, Kevin Krammer and Michael Bohlender.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> These is the basic outline of my receiver model, I wanted to have a review of this before further implementing the .cpp file.
> 
> 
> Diffs
> -----
> 
>   mobile/api/mail/CMakeLists.txt 9fceb28 
>   mobile/api/mail/receivermodel.h PRE-CREATION 
>   mobile/api/mail/receivermodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118663/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/