[Kde-pim] Will not package kdepim-runtime for 4.13.2 with failing tests

[Martin Steigerwald]

Am Sonntag, 8. Juni 2014, 18:05:25 schrieb Albert Astals Cid:
> El Diumenge, 8 de juny de 2014, a les 17:15:10, Kevin Krammer va escriure:
> > On Sunday, 2014-06-08, 16:48:53, Martin Steigerwald wrote:
> > > Hi Albert, hi Kevin, hi Daniel, hi KDEPIM devs,
> > > 
> > > 
> > > If there is anything missing, please enlighten me as to what. As I do
> > > not
> > > know what it is. Please consider that I am a newbie in all of this and
> > > do
> > > not magically know all possible pitfalls regarding testcases in KDEPIM.
> > > 
> > > The only idea I have still left is that moving down the sorting to the
> > > tagListHash.contains may unveilled that another tests fails *sometimes*,
> > > depending on the unsorted order of the entries, but that doesn´t match
> > > 
> > > FAIL!  : ItemFetchTest::testListingMaildir() '!tagListHash.contains(
> > > items[
> > > 0 ].remoteId() )' returned FALSE. ()
> > > 
> > >    Loc: [/srv/jenkins/workspace/kdepim-
> > > 
> > > runtime_stable/resources/mixedmaildir/tests/itemfetchtest.cpp(376)]
> > > 
> > > from
> > > 
> > > http://build.kde.org/view/KDE SC stable/job/kdepim-
> > > runtime_stable/lastCompletedBuild/testReport/(root)/TestSuite/mixedmaild
> > > ir
> > > _i temfetchtest/
> > 
> > The items used to be sorted by file name, i.e.  basically by their remote
> > ID.
> > 
> > I think qSort(items) uses Entity::operator<() which sorts by Item ID.
> > 
> > You'll most likely need a "less than" function, something like
> > 
> > static bool itemLessThanByRemoteId(const Item &item1, const Item &item2)
> > {
> > 
> >     return item1.remoteId() < item2.remoteId();
> > 
> > }
> > 
> > qSort(items.begin(), items.end(), itemLessThanByRemoteId);
> 
> This does defenitely make the test pass.
> 
> Should I commit it? Or you Kevin want to do it?

I am preparing a patch right now.

Thanks,
-- 
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA  B82F 991B EAAC A599 84C7
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20140608/a1159d74/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/