[Kde-pim] Review Request 118919: Outline for sending the message.

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118919/#review61011
-----------------------------------------------------------



mobile/CMakeLists.txt
<https://git.reviewboard.kde.org/r/118919/#comment42496>

    you can leave those in if you explicitly tell the compiler how to convert string literals, e.g.
    
    QString s1 = QLatin1String( "somelatin1string" );
    QString s2 = QString::fromUtf( "someutf8string" );



mobile/api/mail/composer.cpp
<https://git.reviewboard.kde.org/r/118919/#comment42497>

    maybe use m_subject already?



mobile/api/mail/composer.cpp
<https://git.reviewboard.kde.org/r/118919/#comment42498>

    pass "this" as the object's parent, so that it will get deleted when the composer is


- Kevin Krammer


On June 26, 2014, 9:01 a.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118919/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 9:01 a.m.)
> 
> 
> Review request for KDEPIM, Kevin Krammer and Michael Bohlender.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> I have tried two approaches for sending part of mail. I still have to extend them. I feel approach 2 in send2.h and send2.cpp will be better. I still have to extend them. Will approach 2 work with the send function in messagesender.h? Re using the code as in approach 1 is getting a bit complicated. I will change the CMakeListst.txt ( Mobile) back again ( add definitions.. )  again after testing.
> 
> 
> Diffs
> -----
> 
>   mobile/CMakeLists.txt aca765d 
>   mobile/api/mail/CMakeLists.txt 27ab592 
>   mobile/api/mail/composer.h 2dfa16a 
>   mobile/api/mail/composer.cpp 20333d1 
>   mobile/api/mail/mailplugin.cpp bf1bf40 
>   mobile/api/mail/main.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118919/diff/
> 
> 
> Testing
> -------
> 
> When I click the screen , i get the following output on the console:
> plasmoidviewer(16808)/kdecore (K*TimeZone*): No time zone information obtained from ktimezoned 
> 
> And I don't receive a mail in my inbox or spam.
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/