[Kde-pim] Review Request 118916: KIMAP: Add support for XOAUTH2 authentication method

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118916/#review60953
-----------------------------------------------------------


IMO shipping the plugin with kimap would make sense. But let's wait with that until we get the time to fully review it. I don't see any urgency in getting this under the BIC guarantees.

- Christian Mollekopf


On June 24, 2014, 11:26 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118916/
> -----------------------------------------------------------
> 
> (Updated June 24, 2014, 11:26 a.m.)
> 
> 
> Review request for KDEPIM-Libraries and Christian Mollekopf.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> XOAUTH2 is used by Gmail to authenticate via OAuth tokens instead of regular
> username + password.
> 
> This adds support for XOAUTH2 to KIMAP. However cyrus-sasl does not support
> XOAUTH2 out of the box. For clients being able to use XOAUTH2, a 3rd-party
> SASL plugin must be provided (until upstream supports it).
> 
> A simple XOAUTH2 cyrus-sasl plugin is currently in kdepim-runtime/resources/gmail in gmail-resource branch. Do you think it should be shipped with KIMAP instead?
> 
> 
> Diffs
> -----
> 
>   kimap/loginjob.h 2c6040a74aa99e8933d7619b7de072f64934c363 
>   kimap/loginjob.cpp b372c7e185060b9c199cf3fdd0f857d94cc54919 
> 
> Diff: https://git.reviewboard.kde.org/r/118916/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/