[Kde-pim] Review Request 118608: Review for API - mail composer class

[Michael Bohlender]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118608/#review59600
-----------------------------------------------------------



mobile/api/mail/composer.h
<https://git.reviewboard.kde.org/r/118608/#comment41531>

    I am not happy with the wording here. 
    If you are the frist to write a mail, you do not reply. so maybe just call it "to" ?



mobile/api/mail/composer.h
<https://git.reviewboard.kde.org/r/118608/#comment41530>

    Didn't we agree on having slots for "addCc(email)" and removeCc(email) instead of the setCc() ?
    same for the other lists


- Michael Bohlender


On June 8, 2014, 10:12 p.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118608/
> -----------------------------------------------------------
> 
> (Updated June 8, 2014, 10:12 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Api for Creating the text Mail. I have also added the function for sending the mail. Sending the mail part is yet to be tested.
> 
> 
> Diffs
> -----
> 
>   mobile/api/mail/CMakeLists.txt ef1c3ff 
>   mobile/api/mail/composer.h PRE-CREATION 
>   mobile/api/mail/composer.cpp PRE-CREATION 
>   mobile/api/mail/folderlist.h 06f92f2 
>   mobile/api/mail/mailplugin.cpp 42f0df7 
> 
> Diff: https://git.reviewboard.kde.org/r/118608/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/