[Kde-pim] Review Request 118602: Speed up opening the folder properties dialog in kmail.

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118602/#review59516
-----------------------------------------------------------


Looks good to me. I don't think we can improve it much beyond that until we start supporting running certain tasks concurrently.

- Christian Mollekopf


On June 7, 2014, 9:07 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118602/
> -----------------------------------------------------------
> 
> (Updated June 7, 2014, 9:07 a.m.)
> 
> 
> Review request for KDEPIM-Libraries, Dan Vrátil, Laurent Montel, and Volker Krause.
> 
> 
> Bugs: 314876 and 325756
>     http://bugs.kde.org/show_bug.cgi?id=314876
>     http://bugs.kde.org/show_bug.cgi?id=325756
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> Speed up opening the folder properties dialog in kmail.
> 
> An IMAP mail check schedules a large number of tasks.
> Tasks that the user is waiting for, such as ItemFetch (reading one mail)
> or SyncCollectionAttributes (as called by the folder properties dialog)
> should have priority over that.
> 
> There might be more types of tasks that the user could potentially be waiting for.
> Maybe we could even blacklist instead of whitelist, i.e. put folder-sync tasks
> in a low-prio queue, while the default queue would be above it. Not sure.
> 
> 
> Diffs
> -----
> 
>   akonadi/resourcescheduler.cpp 0c57a09d1f3480487cf4f02820d50d62232fd288 
>   akonadi/resourcescheduler_p.h 4f8f079dc73e8ae82e3eb31b2102f204287887e1 
> 
> Diff: https://git.reviewboard.kde.org/r/118602/diff/
> 
> 
> Testing
> -------
> 
> Ctrl+L (trigger full mail sync), RMB on folder, Folder Properties
> Before: it would wait for all folders to be synced, before showing the dialog
> After: it only waits for the currently-synced folder to be done, and then shows the dialog
> 
> It would be better if it was immediate, of course...
> 
> 
> Thanks,
> 
> David Faure
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/