[Kde-pim] Review Request 118919: Outline for sending the message.

[Abhijeet Nikam]

> On June 26, 2014, 3:16 p.m., Michael Bohlender wrote:
> > mobile/api/mail/CMakeLists.txt, line 18
> > <https://git.reviewboard.kde.org/r/118919/diff/4/?file=284839#file284839line18>
> >
> >     same as above
> >

Yes, we don't need this. Removed it. But we need libkdepim for it to compile.


> On June 26, 2014, 3:16 p.m., Michael Bohlender wrote:
> > mobile/api/mail/composer.cpp, line 98
> > <https://git.reviewboard.kde.org/r/118919/diff/4/?file=284841#file284841line98>
> >
> >     why?

The present Mime meassage takes arguments as QString for from, to, cc,bcc -> So I made all of them QString for now. I'll add a QStringList to QString converter in the next review


> On June 26, 2014, 3:16 p.m., Michael Bohlender wrote:
> > mobile/api/mail/main.qml, line 1
> > <https://git.reviewboard.kde.org/r/118919/diff/4/?file=284842#file284842line1>
> >
> >     abvously leave this out of the final commit

I thought of adding the test qml file. I'll remove it the next time.


> On June 26, 2014, 3:16 p.m., Michael Bohlender wrote:
> > mobile/api/mail/main.qml, line 2
> > <https://git.reviewboard.kde.org/r/118919/diff/4/?file=284842#file284842line2>
> >
> >     make sure to put your name in the copyright for files that you want to commit ;)

Yes, I'll remember that :)


- Abhijeet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118919/#review61034
-----------------------------------------------------------


On June 26, 2014, 1:23 p.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118919/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 1:23 p.m.)
> 
> 
> Review request for KDEPIM, Kevin Krammer and Michael Bohlender.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> I have tried two approaches for sending part of mail. I still have to extend them. I feel approach 2 in send2.h and send2.cpp will be better. I still have to extend them. Will approach 2 work with the send function in messagesender.h? Re using the code as in approach 1 is getting a bit complicated. I will change the CMakeListst.txt ( Mobile) back again ( add definitions.. )  again after testing.
> 
> 
> Diffs
> -----
> 
>   mobile/api/mail/CMakeLists.txt 27ab592 
>   mobile/api/mail/composer.h 2dfa16a 
>   mobile/api/mail/composer.cpp 20333d1 
>   mobile/api/mail/main.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118919/diff/
> 
> 
> Testing
> -------
> 
> When I click the screen , i get the following output on the console:
> plasmoidviewer(16808)/kdecore (K*TimeZone*): No time zone information obtained from ktimezoned 
> 
> And I don't receive a mail in my inbox or spam.
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/