[Kde-pim] Review Request 118726: Display Organization Unit in addresslineedit

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118726/#review60894
-----------------------------------------------------------



libkdepim/addressline/addresseelineedit.cpp
<https://git.reviewboard.kde.org/r/118726/#comment42413>

    Minor optimization.
    We can write:
    const QString rdnStr = result.dn.rdnString(i);
    
    => if (rdnStr.start...) {
           ou = rdnStr.mid(3);


- Laurent Montel


On June 24, 2014, 8:31 a.m., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118726/
> -----------------------------------------------------------
> 
> (Updated June 24, 2014, 8:31 a.m.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> When using a large LDAP Server, it is nice to see in what organization unit one specific address comes from. 
> We display the ou after the mailaddress autocompletion list like this:
> 
> "John Doe" <doe at example.com> (staff)
> "John Doe" <master at example.com> (customer)
> 
> If it is used as mailadress(enter/mouse etc.), the ou part is stripped out before.
> 
> The Display OU is configurable via context Menu.
> 
> 
> Diffs
> -----
> 
>   libkdepim/ldap/ldapclientsearch.cpp 5045927c1e9b5e05618c9f1b2e8d20fb1fcb0cf7 
>   libkdepim/ldap/ldapclientsearch.h 933540981a1b86eaa8104414255c78a3a40d0f0e 
>   libkdepim/addressline/addresseelineedit.cpp b0bda31de893ef5c62abcbda803636756081e84f 
>   libkdepim/addressline/addresseelineedit.h 7d458d70cc7935138c8b168c62ddfd762dc76584 
> 
> Diff: https://git.reviewboard.kde.org/r/118726/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/