[Kde-pim] Review Request 118919: Outline for sending the message.

Abhijeet Nikam connect08nikam at gmail.com
Thu Jun 26 20:30:44 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118919/
-----------------------------------------------------------

(Updated June 26, 2014, 7:30 p.m.)


Review request for KDEPIM, Kevin Krammer and Michael Bohlender.


Changes
-------

Added the whitespace and removed the newline.


Repository: kdepim


Description
-------

I have tried two approaches for sending part of mail. I still have to extend them. I feel approach 2 in send2.h and send2.cpp will be better. I still have to extend them. Will approach 2 work with the send function in messagesender.h? Re using the code as in approach 1 is getting a bit complicated. I will change the CMakeListst.txt ( Mobile) back again ( add definitions.. )  again after testing.


Diffs (updated)
-----

  mobile/api/mail/CMakeLists.txt 27ab592 
  mobile/api/mail/composer.h 2dfa16a 
  mobile/api/mail/composer.cpp 20333d1 

Diff: https://git.reviewboard.kde.org/r/118919/diff/


Testing
-------

When I click the screen , i get the following output on the console:
plasmoidviewer(16808)/kdecore (K*TimeZone*): No time zone information obtained from ktimezoned 

And I don't receive a mail in my inbox or spam.


Thanks,

Abhijeet Nikam

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list