[Kde-pim] Review Request 118663: Outline of the receiver model

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118663/#review59762
-----------------------------------------------------------



mobile/api/mail/receivermodel.h
<https://git.reviewboard.kde.org/r/118663/#comment41645>

    just <QAbstractListModel>



mobile/api/mail/receivermodel.h
<https://git.reviewboard.kde.org/r/118663/#comment41646>

    Class names start with capital letters



mobile/api/mail/receivermodel.h
<https://git.reviewboard.kde.org/r/118663/#comment41647>

    you don't need these properties, each of these values will be available as data roles for each entry.
    
    But you need the role values for these three roles, usually as an enum


- Kevin Krammer


On June 11, 2014, 8:55 a.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118663/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 8:55 a.m.)
> 
> 
> Review request for KDEPIM, Kevin Krammer and Michael Bohlender.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> These is the basic outline of my receiver model, I wanted to have a review of this before further implementing the .cpp file.
> 
> 
> Diffs
> -----
> 
>   mobile/api/mail/receivermodel.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118663/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/