[Kde-pim] Review Request 118525: Support for enabled state of collcetions

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118525/#review59327
-----------------------------------------------------------



akonadi/collection.h
<https://git.reviewboard.kde.org/r/118525/#comment41277>

    There should be API documentation to describe what the enum and its values mean. The meaning isn't obvious. Dan's suggested renaming would help, but still needs some comments.



akonadi/collection.h
<https://git.reviewboard.kde.org/r/118525/#comment41278>

    Add comments to describe the enum and its values. This would help people to understand what local lists are about. (There is currently no clear overall summary of their purpose.)



akonadi/collection.h
<https://git.reviewboard.kde.org/r/118525/#comment41279>

    whether



akonadi/collection.cpp
<https://git.reviewboard.kde.org/r/118525/#comment41280>

    Check that enabled has changed before setting enabledChanged.



akonadi/collectionfetchscope.h
<https://git.reviewboard.kde.org/r/118525/#comment41284>

    Needs comments to describe the enum and its values.



akonadi/collectionfetchscope.h
<https://git.reviewboard.kde.org/r/118525/#comment41283>

    Collections that are "not part of the collection" - what does that mean?



akonadi/entitytreemodel_p.cpp
<https://git.reviewboard.kde.org/r/118525/#comment41285>

    Is the double qualifier "CollectionFetchScope::" correct/necessary?


- David Jarvie


On June 4, 2014, 7:27 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118525/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 7:27 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Dan Vrátil.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> This patch adds support for the enabled state for all required parts of kdepimlibs.
> 
> 
> Diffs
> -----
> 
>   akonadi/collection.h 8539a370ee1b7aa81b3bf0d5007f68ccf65893be 
>   akonadi/collection.cpp 9b12f93d4ab421ec0a2ac7706637767f5adff2a7 
>   akonadi/collection_p.h a3e48729d8083deadaa1b4da155881f8739f3239 
>   akonadi/collectioncreatejob.cpp 7b2f3734b7225d352ecf3ebcf911458d334e8378 
>   akonadi/collectionfetchjob.cpp 5b17eb8649dce680153ca08c7c66d614297ab955 
>   akonadi/collectionfetchscope.h 80184ed409f569699c8493ae2b5264593f19f86a 
>   akonadi/collectionfetchscope.cpp 9636e25013002d402c04fe63ddd4d9607c806d08 
>   akonadi/collectionmodifyjob.cpp f735106856e927a510d0b108c99fda137e0cfd0b 
>   akonadi/entitytreemodel.h d7f40e31bc5cad4b38e53760f6dfb21ebc1fa69a 
>   akonadi/entitytreemodel.cpp ef496c677a7f7b54b9eca23e74bb7e69f00ac61f 
>   akonadi/entitytreemodel_p.h d50dc5535e62b1df591afd11c4ad3f8d82c2bc0b 
>   akonadi/entitytreemodel_p.cpp ebf497383ad6775c94451babc763248fb19a6606 
>   akonadi/protocolhelper.cpp 63d3f7f758dae77035c4822ce0c1fec38c824ca6 
>   akonadi/protocolhelper_p.h ddbb97323070bf1f41674e17b99ea1e9420306a4 
>   akonadi/resourcebase.cpp 50c92924a33730842d8dc9b78cb9a7b35dd9c9ee 
>   akonadi/tests/collectionjobtest.h 2d08cd0a336b4c992872e49c6ee2c54a0b93b1cc 
>   akonadi/tests/collectionjobtest.cpp fc8202e8140636714ba39be1171e2ae27f9e9b55 
> 
> Diff: https://git.reviewboard.kde.org/r/118525/diff/
> 
> 
> Testing
> -------
> 
> I verified that local subscriptions still work in kmail as they used to and unittested the enabled/listPreference mechanism.
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/