[Kde-pim] Review Request 118609: Changes made in the API folder - CMAKELISTS.txt and others
Michael Bohlender
michael.bohlender at kdemail.net
Sun Jun 8 09:02:51 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118609/#review59537
-----------------------------------------------------------
mobile/api/mail/CMakeLists.txt
<https://git.reviewboard.kde.org/r/118609/#comment41488>
is it really nessesary to include all of these? please only include what is needed for the moment. so we can keep a clean cmakelist.txt
mobile/api/mail/CMakeLists.txt
<https://git.reviewboard.kde.org/r/118609/#comment41489>
is this really nessesary?
- Michael Bohlender
On June 7, 2014, 9:31 p.m., Abhijeet Nikam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118609/
> -----------------------------------------------------------
>
> (Updated June 7, 2014, 9:31 p.m.)
>
>
> Review request for KDEPIM and Kevin Krammer.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> I could not manage the patches in same diff. I have added the required things in cmakelist.txt (like linked libraries etc) which may be needed in future and made some neccessary changes in the mail plugin (register the class).
>
>
> Diffs
> -----
>
> mobile/api/mail/CMakeLists.txt ef1c3ff
> mobile/api/mail/folderlist.h 06f92f2
> mobile/api/mail/mailplugin.cpp 42f0df7
>
> Diff: https://git.reviewboard.kde.org/r/118609/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Abhijeet Nikam
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list