[Kde-pim] Review Request 118663: Outline of the receiver model

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118663/#review60941
-----------------------------------------------------------



mobile/api/mail/composer.h
<https://git.reviewboard.kde.org/r/118663/#comment42444>

    in general, local (project) includes before global includes (like Qt or KDE libs).
    
    and project local includes in double quotes instead of angle brackets, i.e. "receivermodel.h" instead of <receivermodel.h>
    
    Reason for this are lookup rules, we want to be sure the local header is found first.



mobile/api/mail/composer.h
<https://git.reviewboard.kde.org/r/118663/#comment42445>

    I think in Q_PROPERTY macros we put the * at the type



mobile/api/mail/mailplugin.cpp
<https://git.reviewboard.kde.org/r/118663/#comment42446>

    trailing whitespace



mobile/api/mail/receivermodel.h
<https://git.reviewboard.kde.org/r/118663/#comment42449>

    doesn't that trigger a compiler warning?
    the base class has a method with the almost the same signature.
    And that signature is the one that needs to be overwritten in Qt5. so if this is just a helper for now, maybe make it a stand-alone function inside the cpp file



mobile/api/mail/receivermodel.h
<https://git.reviewboard.kde.org/r/118663/#comment42451>

    What does the type mean here in the context of the model?
    Doesn't the model contain recievers of all types?



mobile/api/mail/receivermodel.cpp
<https://git.reviewboard.kde.org/r/118663/#comment42452>

    shouldn't the type be take from value as well?
    Or do I misunderstand how the model is to be used?



mobile/api/mail/recipient.h
<https://git.reviewboard.kde.org/r/118663/#comment42454>

    is the existing recipient class not sufficient?


- Kevin Krammer


On June 25, 2014, 7:14 a.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118663/
> -----------------------------------------------------------
> 
> (Updated June 25, 2014, 7:14 a.m.)
> 
> 
> Review request for KDEPIM, Kevin Krammer and Michael Bohlender.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> These is the basic outline of my receiver model, I wanted to have a review of this before further implementing the .cpp file.
> 
> 
> Diffs
> -----
> 
>   mobile/CMakeLists.txt aca765d 
>   mobile/api/mail/CMakeLists.txt 27ab592 
>   mobile/api/mail/composer.h 2dfa16a 
>   mobile/api/mail/composer.cpp 20333d1 
>   mobile/api/mail/mailplugin.cpp bf1bf40 
>   mobile/api/mail/receivermodel.h PRE-CREATION 
>   mobile/api/mail/receivermodel.cpp PRE-CREATION 
>   mobile/api/mail/recipient.h PRE-CREATION 
>   mobile/api/mail/recipient.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118663/diff/
> 
> 
> Testing
> -------
> 
> Compiles without any errors.
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/