[Kde-pim] Review Request 118608: Review for API - mail composer class

[Abhijeet Nikam]

> On June 9, 2014, 9:51 a.m., Michael Bohlender wrote:
> > mobile/api/mail/composer.h, line 49
> > <https://git.reviewboard.kde.org/r/118608/diff/5/?file=279768#file279768line49>
> >
> >     Didn't we agree on having slots for "addCc(email)" and removeCc(email) instead of the setCc() ?
> >     same for the other lists
> 
> Kevin Krammer wrote:
>     I don't think having list manipulation functions is worth the effort. After all these are most likely going to be replaced with a model anyway.
>

How should I go about the model? Any example which I can refer to?


> On June 9, 2014, 9:51 a.m., Michael Bohlender wrote:
> > mobile/api/mail/composer.h, line 35
> > <https://git.reviewboard.kde.org/r/118608/diff/5/?file=279768#file279768line35>
> >
> >     I am not happy with the wording here. 
> >     If you are the frist to write a mail, you do not reply. so maybe just call it "to" ?
> 
> Kevin Krammer wrote:
>     good point. "reply to" usually refers to the address that you want the other party to reply to. I.e. if they should send replies to a different address then the one in "from"

yes, I have changed that now


- Abhijeet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118608/#review59600
-----------------------------------------------------------


On June 8, 2014, 10:12 p.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118608/
> -----------------------------------------------------------
> 
> (Updated June 8, 2014, 10:12 p.m.)
> 
> 
> Review request for KDEPIM and Kevin Krammer.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> Api for Creating the text Mail. I have also added the function for sending the mail. Sending the mail part is yet to be tested.
> 
> 
> Diffs
> -----
> 
>   mobile/api/mail/CMakeLists.txt ef1c3ff 
>   mobile/api/mail/composer.h PRE-CREATION 
>   mobile/api/mail/composer.cpp PRE-CREATION 
>   mobile/api/mail/folderlist.h 06f92f2 
>   mobile/api/mail/mailplugin.cpp 42f0df7 
> 
> Diff: https://git.reviewboard.kde.org/r/118608/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/