[Kde-pim] Review Request 118781: KIMAP: Add support for Gmail-specific protocol extensions

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118781/#review60820
-----------------------------------------------------------


Hi,

just realized that this is not a BC change. Would you be OK with adding (set)GmailExtensionsEnabled(bool) setter/getter that would just enable all three features? For KF5 I propose we make the FetchScope a proper PIMPL class like Akonadi::ItemFetchScope to avoid these problems in the future.

- Dan Vrátil


On June 16, 2014, 3:38 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118781/
> -----------------------------------------------------------
> 
> (Updated June 16, 2014, 3:38 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Christian Mollekopf.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> This patch adds support for Gmail-specific IMAP extensions to KIMAP's FetchJob.
> 
> Overloads for partsReceived(), headersReceived() and messagesReceived() signals are added that have an additional QMap<qint64, QPair<QString, QVariant>> (typedef'ed as QMap<qint64, MessageAttribute>) argument that can contain multimap of additional FETCH response attributes. This solution will also scale in future if we add support for additional IMAP extensions that provide more information in FETCH responses, currently it will contain X-GM-MSGID, X-GM-THRID and X-GM-LABELS attributes (if enabled in KIMAP::FetchScope)
> 
> 
> Diffs
> -----
> 
>   kimap/fetchjob.h 01a5712 
>   kimap/fetchjob.cpp fa49fbd 
>   kimap/tests/fetchjobtest.cpp b1c29a3 
> 
> Diff: https://git.reviewboard.kde.org/r/118781/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/