[Kde-pim] Review Request 118919: Outline for sending the message.

[Michael Bohlender]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118919/#review60930
-----------------------------------------------------------


When you were able to send a mail from C++ with this than this approach is fine for now.
Kevin will have the final say on this though.

Please make sure to have review requests about one topic only. so either "add recipientsmodel property" or "send mail"
git branches make this really easy. Ask me on the meeting today and I am happy to explain it to you.



mobile/api/mail/CMakeLists.txt
<https://git.reviewboard.kde.org/r/118919/#comment42432>

    this should not be part of this review



mobile/api/mail/CMakeLists.txt
<https://git.reviewboard.kde.org/r/118919/#comment42433>

    It says further down that this file does not exist.
    



mobile/api/mail/composer.h
<https://git.reviewboard.kde.org/r/118919/#comment42434>

    Kevin told me that Q_PROPERTY is an exception for coding style. 
    
    so it is .....TY (RecMod* model ...
    
    Also "model" is a bad name for the property.
    I would assume to get a model of all the data of the composer when I look at "composer.model" so maybe change the name ?



mobile/api/mail/composer.h
<https://git.reviewboard.kde.org/r/118919/#comment42435>

    Do you really need a serperate class for sending ? Why not just put it in the "send()" slot? 



mobile/api/mail/mailplugin.cpp
<https://git.reviewboard.kde.org/r/118919/#comment42436>

    white space
    
    you can set your editor to delete this when you save. It "saves" :D  you a lot of work.



mobile/api/mail/send2.cpp
<https://git.reviewboard.kde.org/r/118919/#comment42437>

    isn't that a null pointer at this moment?


- Michael Bohlender


On June 25, 2014, 7:04 a.m., Abhijeet Nikam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118919/
> -----------------------------------------------------------
> 
> (Updated June 25, 2014, 7:04 a.m.)
> 
> 
> Review request for KDEPIM, Kevin Krammer and Michael Bohlender.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> I have tried two approaches for sending part of mail. I still have to extend them. I feel approach 2 in send2.h and send2.cpp will be better. I still have to extend them. Will approach 2 work with the send function in messagesender.h? Re using the code as in approach 1 is getting a bit complicated. I will change the CMakeListst.txt ( Mobile) back again ( add definitions.. )  again after testing.
> 
> 
> Diffs
> -----
> 
>   mobile/CMakeLists.txt aca765d 
>   mobile/api/mail/CMakeLists.txt 27ab592 
>   mobile/api/mail/composer.h 2dfa16a 
>   mobile/api/mail/composer.cpp 20333d1 
>   mobile/api/mail/mailplugin.cpp bf1bf40 
>   mobile/api/mail/receivermodel.h c2346ec 
>   mobile/api/mail/receivermodel.cpp 26600a4 
>   mobile/api/mail/recipient.h 5b7e317 
>   mobile/api/mail/recipient.cpp 06e822b 
>   mobile/api/mail/send2.h PRE-CREATION 
>   mobile/api/mail/send2.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118919/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abhijeet Nikam
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/