[Kde-pim] Review Request 118663: Outline of the receiver model

Abhijeet Nikam connect08nikam at gmail.com
Thu Jun 26 06:25:03 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118663/
-----------------------------------------------------------

(Updated June 26, 2014, 5:25 a.m.)


Review request for KDEPIM, Kevin Krammer and Michael Bohlender.


Changes
-------

This is how I am testing the receiver model. I have added the QML file which I run with plasmoidviewer.  I was unable to pass the enum value in setType() so I used Recipient::idToType() which converts the integer to enum Type. I have defined the roles in the constructor. I get undefined:undefined:undefined 2 times as the output. 


Repository: kdepim


Description
-------

These is the basic outline of my receiver model, I wanted to have a review of this before further implementing the .cpp file.


Diffs (updated)
-----

  messagecomposer/recipient/recipient.h 0eea70b 
  messagecomposer/recipient/recipient.cpp 3a63625 
  mobile/CMakeLists.txt aca765d 
  mobile/api/mail/CMakeLists.txt 27ab592 
  mobile/api/mail/mailplugin.cpp bf1bf40 
  mobile/api/mail/main.qml PRE-CREATION 
  mobile/api/mail/receivermodel.h PRE-CREATION 
  mobile/api/mail/receivermodel.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/118663/diff/


Testing
-------

Compiles without any errors.


Thanks,

Abhijeet Nikam

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list