[Kde-pim] Review Request 119320: TagAppend: fix repeated appends with merge enabled
Dan Vrátil
dvratil at redhat.com
Thu Jul 17 09:11:59 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119320/#review62552
-----------------------------------------------------------
server/src/handler/tagappend.cpp
<https://git.reviewboard.kde.org/r/119320/#comment43398>
I know this is not related to your change, but could you alter this to be just
const qint64 resourceId = connection()->context()->resource().id()
and adapt the rest of the code accordingly? The point is to avoid unnecessary retrieveByName() call, because we only need the resource ID here, which we already have.
server/src/handler/tagappend.cpp
<https://git.reviewboard.kde.org/r/119320/#comment43396>
Throw HandlerException when the query fails
- Dan Vrátil
On July 17, 2014, 12:42 a.m., Christian Mollekopf wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119320/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 12:42 a.m.)
>
>
> Review request for Akonadi, Dan Vrátil and Kevin Ottens.
>
>
> Repository: akonadi
>
>
> Description
> -------
>
> TagAppend: fix repeated appends with merge enabled
>
> This was triggered by the knutresource which creates it's tags everytime
> it's syncing collections.
>
>
> Diffs
> -----
>
> server/src/handler/tagappend.cpp 5786325fdedc1e3ed2edf2922f97daae1d1e0203
>
> Diff: https://git.reviewboard.kde.org/r/119320/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christian Mollekopf
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list