[Kde-pim] Review Request 119420: added CollectionIdentificationAttribute

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119420/#review62940
-----------------------------------------------------------



akonadi/collectionidentificationattribute.cpp
<https://git.reviewboard.kde.org/r/119420/#comment43615>

    The d pointer will leak when CollectionIdentificationAttibute is deleted.



akonadi/collectionidentificationattribute.cpp
<https://git.reviewboard.kde.org/r/119420/#comment43616>

    Is "%" a safe separator? Wouldn't be QTextStream, or at least some non-printable character, like \001 safer?


- Dan Vrátil


On July 23, 2014, 12:41 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119420/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 12:41 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> added CollectionIdentificationAttribute
> 
> I'm using this attribute to indicate user folders from imap, so I can represent them accordingly in the UI. Additionally should the identifier make it possible to query for a user collection based on a retrieved ldap record for said user.
> Both identifier and namespae and identifier will be indexed by baloo to make it queriable.
> 
> 
> Diffs
> -----
> 
>   akonadi/CMakeLists.txt a6fc0aa83b86d09119286e700e88d029564f0e5c 
>   akonadi/collectionidentificationattribute.h PRE-CREATION 
>   akonadi/collectionidentificationattribute.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119420/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/