[Kde-pim] Review Request 119469: Fetch tags with items.

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119469/#review63315
-----------------------------------------------------------



akonadi/itemfetchscope.h
<https://git.reviewboard.kde.org/r/119469/#comment44139>

    Why cannot this be part of the TagFetchScope? 
    
    You can modify behavior of the TagFetchScope to include only UID by default, and everythig else has to be turned on. This should not break anything.


- Dan Vrátil


On July 27, 2014, 3:52 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119469/
> -----------------------------------------------------------
> 
> (Updated July 27, 2014, 3:52 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> POC: Fetch tags with items.
> 
> Same as the akonadi part, but I think this code will largely stay as it is, so feel free to review that a bit more in depth.
> 
> 
> Diffs
> -----
> 
>   akonadi/tests/tagtest.cpp f3e2c96e83685780afc9868f2053bcd2f3f8e8f7 
>   akonadi/itemfetchscope.h 7200ad92588c06de8a53032cd4dc40c65c011528 
>   akonadi/itemfetchscope.cpp b5677dfd664555c466710acdc7ad6ebf2309c0fa 
>   akonadi/itemfetchscope_p.h d3668d4790ab25222a6beff8e709616745f2b5b6 
>   akonadi/protocolhelper.cpp 53bb5a959c7145afab58afeeaaa0afcea1d97b51 
>   akonadi/protocolhelper_p.h 844d6367c00e72cc0b1e06e0fc3bde7a63813969 
>   akonadi/tagfetchjob.cpp ff518a8ce848f37ad01e2fa96f84d8f6b44e4117 
> 
> Diff: https://git.reviewboard.kde.org/r/119469/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/