[Kde-pim] Review Request 119462: Per attendee customization of email [4] - individual mail dialog

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119462/#review63147
-----------------------------------------------------------



incidenceeditor-ng/individualmaildialog.cpp
<https://git.reviewboard.kde.org/r/119462/#comment43904>

    is it possible to create another method to check item ?
    if we change in combobox but not here it will not work.
    
    Or better create an unitest about this dialogbox
    It will great to start to unittest all new code.
    (you can see in messagelist/test/quicksearchline.cpp or kmail/tests/identityaddvcarddialogtest.cpp etc.)


- Laurent Montel


On juil. 25, 2014, 12:32 après-midi, Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119462/
> -----------------------------------------------------------
> 
> (Updated juil. 25, 2014, 12:32 après-midi)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> The last patch of this serie.
> Crating the actual individual mail dialog, to select which attendee should get an update and for whom a composer should be opened.
> 
> 
> Diffs
> -----
> 
>   incidenceeditor-ng/CMakeLists.txt 9097780defc9922424b36cdb7f576a806c8f1fd4 
>   incidenceeditor-ng/editoritemmanager.cpp 7cc3614f6343ead48e899c8ff95caaa2a56dd530 
>   incidenceeditor-ng/individualmaildialog.h PRE-CREATION 
>   incidenceeditor-ng/individualmaildialog.cpp PRE-CREATION 
>   incidenceeditor-ng/individualmailjobfactory.h PRE-CREATION 
>   incidenceeditor-ng/individualmailjobfactory.cpp PRE-CREATION 
>   incidenceeditor-ng/opencomposerjob.h PRE-CREATION 
>   incidenceeditor-ng/opencomposerjob.cpp PRE-CREATION 
>   korganizer/calendarview.cpp df3d74139c2363857adecee308b8a0144183f52d 
> 
> Diff: https://git.reviewboard.kde.org/r/119462/diff/
> 
> 
> Testing
> -------
> 
> Sending much of invatations around :)
> 
> 
> File Attachments
> ----------------
> 
> The new dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/07/25/ac439091-58fa-4d8d-a365-810126ff963b__individual-mail.png
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/