[Kde-pim] Review Request 119196: Blogilo: Move Blogger API implementation from KBlog to Blogilo

Laurent Montel montel at kde.org
Wed Jul 9 14:34:17 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119196/#review61975
-----------------------------------------------------------

Ship it!


Ship it.
Just increase kdepimlibs version + kdepim check to avoid a problem with old kblog with same code as in kdepim.
Regards.

- Laurent Montel


On juil. 9, 2014, 12:39 après-midi, Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119196/
> -----------------------------------------------------------
> 
> (Updated juil. 9, 2014, 12:39 après-midi)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> As discussed on IRC, in order to prevent circular dependency between LibKGAPI and kdepimlibs, this patch moves implementation of KBlog's Blogger API to Blogilo.
> 
> I kept the KBlog namespace to make the move eaiser once we revert this in Frameworks again.
> 
> 
> Diffs
> -----
> 
>   blogilo/src/CMakeLists.txt 33bee2f 
>   blogilo/src/addeditblog.cpp fe4eb88 
>   blogilo/src/backend.cpp 84341a4 
>   blogilo/src/bilboblog.cpp 8683410 
>   blogilo/src/blog_p.h PRE-CREATION 
>   blogilo/src/blogger.h PRE-CREATION 
>   blogilo/src/blogger.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119196/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list