[Kde-pim] Review Request 119461: Per attendee customization of email [3] - Add paramenter to ensure the composer to open

Sandro Knauß knauss at kolabsys.com
Fri Jul 25 13:55:24 BST 2014



> On Juli 25, 2014, 12:42 nachm., Laurent Montel wrote:
> > kmail/kmkernel.h, line 220
> > <https://git.reviewboard.kde.org/r/119461/diff/1/?file=292664#file292664line220>
> >
> >     why export it ?
> >     Why don't use KDE_DEPRECATED directory ?

KMAIL_EXPORT_DEPRECATED -> KDE_DEPRECATED I missread the macro -> KDE_DEPRECATED is enough


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119461/#review63141
-----------------------------------------------------------


On Juli 25, 2014, 12:22 nachm., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119461/
> -----------------------------------------------------------
> 
> (Updated Juli 25, 2014, 12:22 nachm.)
> 
> 
> Review request for KDEPIM.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> The actual openComposer method dosen't open an dialog if it is a itip invitation or the user wants automatic sending. 
> But for actually get individual mails for event attendees, we must to make sure that the composer is openend.
> + small bugfix setParameter( QLatin1String(attachParamAttr), attachParamValue ) has to be set to contentType and not to contentDisposition
> 
> 
> Diffs
> -----
> 
>   kmail/kmkernel.h bdad69fadfe1fdd0a7b3734b74673c34d5208977 
>   kmail/kmkernel.cpp f4cb34120c7273158d544a1ee3fa23a02ed815c3 
> 
> Diff: https://git.reviewboard.kde.org/r/119461/diff/
> 
> 
> Testing
> -------
> 
> sent some invations around to make sure they are corret.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list