[Kde-pim] Review Request 119206: Reply types and forward part in the API.

[Abhijeet Nikam]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119206/
-----------------------------------------------------------

(Updated July 12, 2014, 12:28 p.m.)


Review request for KDEPIM, Kevin Krammer and Michael Bohlender.


Changes
-------

I was not able to use the id, so i am sticking with the use of url to retrieve the message. I have added the SetMessage function. I have to only check the recipients part once. I tried using the identity in from, but I get segmentation fault each time. I tried using ( new KDEPIMIdentities::IdentityCombo ), but I get errors with that. I have commented it for now. 


Repository: kdepim


Description
-------

I have added the slots for 4 types of replies and one for forwarding. I am using the slot for retrieving the message from the URL twice.

I tried a lot, passing the enum value for type of reply eg ( reply ( url, MessageComposer::ReplyAll) ) in the reply slots but failed to do so, so I have declared an enum type and assigned the value to it in the reply slots, in the main composer file.

Secondly, Is this approach ok ( using the url and using the same code twice for forward and reply ) or should I shift to the present approach of mobile mail, using item id, and Kjob?

Third thing, without including kdepim in the cmakelists.txt file, it doesn't compile and gives link errors. Any alternative to that?


Diffs (updated)
-----

  mobile/api/mail/CMakeLists.txt d280d62 
  mobile/api/mail/composer.h b731287 
  mobile/api/mail/composer.cpp dc750e8 
  mobile/api/mail/receivermodel.h b0818aa 
  mobile/api/mail/receivermodel.cpp 9bc69e8 

Diff: https://git.reviewboard.kde.org/r/119206/diff/


Testing
-------

I got some mixed results with testing. All the functions seem to work fine, but I feel results are not the same as I expected, or maybe I have gone wrong in testing.

ReplyToAuthor and forwarding works well.

For 3 recipionts in an email,
ReplyToMessage - sends a reply to all the 3 recipients in the to field whereas 
ReplyToAll-> sends the first recipient in the to field, and others as CC.

Is this how it is supposed to be?

ReplyToList - when tested with a mailng list ( kdepim's mailing list ) or even a normal mail
qDebug() -> to filed of the message give a null string. Same message for replyToMessage gives a normal, expected results. Do I need to specify or create a lists for testing? 


Thanks,

Abhijeet Nikam

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/