[Kde-pim] Review Request 119491: CollectionSync: split sync transaction into multiple smaller transactions

Dan Vrátil dvratil at redhat.com
Sat Jul 26 17:13:52 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119491/
-----------------------------------------------------------

Review request for KDEPIM-Libraries and Christian Mollekopf.


Repository: kdepimlibs


Description
-------

As it turned out creating a large amount of collections via CollectionSync is extremely slow when it all happens within one TransactionSequence, because for the Server it means a single database transaction. And appending thousands of INSERTs into the transaction journal is rather slow with all database backends we support.

This patch just commits the TransactionSequence after every 100 collections, which results in a huuuge performance improvement (CollectionSync with 100k collections wnt down from ~20 minutes to ~1 minute).


Diffs
-----

  akonadi/collectionsync.cpp 1a9f760 

Diff: https://git.reviewboard.kde.org/r/119491/diff/


Testing
-------

collectionsynctest still passes


Thanks,

Dan Vrátil

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list