[Kde-pim] Review Request 119292: Remove the conflict resolution dialog from akonadi.

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119292/#review62386
-----------------------------------------------------------


I won't approve this.

Library showing dialogs is perfectly fine. The dialog is there to prevent data loss. Conflicts should not happen (and I haven't seen them in a long time), but if it happens it usually indicates a bug somewhere else in Akonadi. When it happens, the dialog is crucial to prevent data loss. Right now your patch will cause the remote change to overwrite any of you local changes. As you said youself: "choosing 'other' is technically wrong" - which is another reason why I cannot accept this patch.

If you have a problem with the dialog poping up all the time, please open a bug report and we can investigate what's causing it and fix the actual bug. But removing the dialog is not a solution. It's not even a workaround.

- Dan Vrátil


On July 15, 2014, 10:34 a.m., Boudewijn Rempt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119292/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, 10:34 a.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> When reading mail with kmail, this diff-like dialog pops up, sometimes twenty, thirty times in a row. A library shouldn't popup dialogs, and users shouldn't be bothered with having to figure out something diff-like. No doubt always choosing "other" is technically wrong, but showing a dialog like this makes the entire application unusable.
> 
> 
> Diffs
> -----
> 
>   akonadi/CMakeLists.txt a6fc0aa 
>   akonadi/conflicthandling/conflicthandler.cpp 2de0948 
>   akonadi/conflicthandling/conflictresolvedialog.cpp 142b581 
>   akonadi/conflicthandling/conflictresolvedialog_p.h 40c673b 
> 
> Diff: https://git.reviewboard.kde.org/r/119292/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Boudewijn Rempt
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/