[Kde-pim] Review Request 119469: POC: Fetch tags with items.

[Christian Mollekopf]

> On July 26, 2014, 12:48 p.m., Dan Vrátil wrote:
> > akonadi/itemfetchscope.h, line 363
> > <https://git.reviewboard.kde.org/r/119469/diff/1/?file=292752#file292752line363>
> >
> >     Why not just have
> >     
> >     TagFetchScope& tagFetchScope()
> >     
> >     like with ItemFetchScope in ItemFetchJob? You can add TagFetchScope::fetchFullTags() if you want an easy way to fetch full tags - this makes more sense as it will allow us the same level of control in TagFetchJob (and less code duplication).

Unless I add an id-only fetch scope, how do we differentiate between fetching only the id and using the fetch scope to fetch the full tag? Note that fetching the complete tag actully means that I just use the TagFetchScope to fetch the tags (instead of id only). So the name may be a bit misleading.


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119469/#review63194
-----------------------------------------------------------


On July 25, 2014, 3:56 p.m., Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119469/
> -----------------------------------------------------------
> 
> (Updated July 25, 2014, 3:56 p.m.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> POC: Fetch tags with items.
> 
> Same as the akonadi part, but I think this code will largely stay as it is, so feel free to review that a bit more in depth.
> 
> 
> Diffs
> -----
> 
>   akonadi/itemfetchscope.h 7200ad92588c06de8a53032cd4dc40c65c011528 
>   akonadi/itemfetchscope.cpp b5677dfd664555c466710acdc7ad6ebf2309c0fa 
>   akonadi/itemfetchscope_p.h d3668d4790ab25222a6beff8e709616745f2b5b6 
>   akonadi/tagfetchjob.cpp ff518a8ce848f37ad01e2fa96f84d8f6b44e4117 
>   akonadi/tests/tagtest.cpp f3e2c96e83685780afc9868f2053bcd2f3f8e8f7 
>   akonadi/protocolhelper.cpp 53bb5a959c7145afab58afeeaaa0afcea1d97b51 
>   akonadi/protocolhelper_p.h 844d6367c00e72cc0b1e06e0fc3bde7a63813969 
> 
> Diff: https://git.reviewboard.kde.org/r/119469/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Mollekopf
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/