[Kde-pim] Review Request 119223: Fix the build of QGpgme in the frameworks branch

[Cristian Oneț]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119223/
-----------------------------------------------------------

(Updated Iulie 20, 2014, 7:28 a.m.)


Review request for KDEPIM-Libraries and Laurent Montel.


Changes
-------

Since this patch was undone I'm trying a different approach since kdepimlibs frameworks is still failing here (can't open gpgme.h). It's strange though that here http://build.kde.org/job/kdepimlibs_frameworks_qt5/ it builds fine. Let me know if this is a problem on my side, I'm using kdesrc-build and 'gpgme-config --cflags' gives me '-I/usr/include/gpgme'.


Repository: kdepimlibs


Description
-------

I'm building the frameworks branch of kdepimlibs using kdesrc-build in a custom folder. Somehow the gpgme includes which are located in '/usr/include/gpgme' do not end up on the compile command line of the QGpgme files. ${GPGME_VANILLA_LIBRARIES} in the target_link_libraries does not seem to be enough so I added ${GPGME_INCLUDES} to target_include_directories.

If this is not the correct approach fee free to discard this request.


Diffs (updated)
-----

  gpgme++/src/CMakeLists.txt 8b3316e 

Diff: https://git.reviewboard.kde.org/r/119223/diff/


Testing
-------

The build with the patch works.


Thanks,

Cristian Oneț

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/