[Kde-pim] Review Request 119433: Use fullName instead of own building the same logic
Sergio Luis Martins
iamsergio at gmail.com
Thu Jul 24 12:34:11 BST 2014
> On July 24, 2014, 11:33 a.m., Sergio Luis Martins wrote:
> > Ship It!
Pitty that KPIMUtils::quoteNameIfNecessary()'s code is duplicated in KCalCore::Person::fullName()
- Sergio Luis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119433/#review63055
-----------------------------------------------------------
On July 23, 2014, 8:38 p.m., Sandro Knauß wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119433/
> -----------------------------------------------------------
>
> (Updated July 23, 2014, 8:38 p.m.)
>
>
> Review request for KDEPIM-Libraries.
>
>
> Repository: kdepimlibs
>
>
> Description
> -------
>
> KCalCore::Attendee has a method to create the fullName like this, su we should use tis method
>
>
> Diffs
> -----
>
> akonadi/calendar/mailclient_p.cpp 2345007b6dac8715f0f10d8a531a65fb98b9cfe5
>
> Diff: https://git.reviewboard.kde.org/r/119433/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sandro Knauß
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list