[Kde-pim] Review Request 119434: Per attendee customization of email [2] - DialogInterception for IncienceChanger

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119434/#review63111
-----------------------------------------------------------



akonadi/calendar/incidencechanger.cpp
<https://git.reviewboard.kde.org/r/119434/#comment43862>

    since the handler should probably not be used afterwards, maybe also set the variable to 0?
    So that if, just in case, someone accidentally uses it again the stack trace will have a null pointer as a very specific hint



akonadi/calendar/incidencechanger.cpp
<https://git.reviewboard.kde.org/r/119434/#comment43863>

    same here



akonadi/calendar/incidencechanger.cpp
<https://git.reviewboard.kde.org/r/119434/#comment43864>

    and here



akonadi/calendar/itiphandlerhelper_p.cpp
<https://git.reviewboard.kde.org/r/119434/#comment43865>

    what does the bool indicate here?
    maybe also something that could gain from using an enum?
    Also preferable "disable" arguments by Q_UNUSED. It makes it a lot easier to add debug output or get the value in a debugger, i.e. without having to change the signature line as well


- Kevin Krammer


On Juli 24, 2014, 7:52 nachm., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119434/
> -----------------------------------------------------------
> 
> (Updated Juli 24, 2014, 7:52 nachm.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> To be able to customize the emails per attendee from an iTip event. The dialogs opened by IncidenceChange has to be interceptable. You can see the both changeset in the dev/individual_mail2 branch.
> 
> 
> Diffs
> -----
> 
>   akonadi/calendar/itiphandler.cpp 2b721999a7219e5dc5cf51b944fa75e502eafb17 
>   akonadi/calendar/itiphandler_p.h 35e895a54ea16ba2708ce0fe9632758f754d612c 
>   akonadi/calendar/itiphandler_p.cpp e62b72bf4bfb041c24598774fe028dbee0d7984d 
>   akonadi/calendar/itiphandlerhelper_p.h 11bc6de05cba8a17d55aba4a0f5514a3aafdac35 
>   akonadi/calendar/itiphandlerhelper_p.cpp ee3b68a0eeff66255069033ea722b3f327dad65a 
>   akonadi/calendar/incidencechanger.cpp aafa8d5158c29ddd92502ef86c49abaab514e52e 
>   akonadi/calendar/incidencechanger_p.h 82bdfa1d424fb847509828a04cf7ff3194dca507 
>   akonadi/calendar/incidencechanger_p.cpp 74cf138a87564e2dc4d1a8e49d45fe5ac620e2e6 
>   akonadi/calendar/itiphandler.h 5c581e7200f30efc69124e17306e9498a7e7589e 
> 
> Diff: https://git.reviewboard.kde.org/r/119434/diff/
> 
> 
> Testing
> -------
> 
> run multiple times kincidenceeditor and korganizer to test and run itiphelpertest and mailclienttest.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/