[Kde-pim] Review Request 119432: Per attendee customization of email [1] - Make MailClient interceptable

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119432/#review63035
-----------------------------------------------------------



akonadi/calendar/incidencechanger.h
<https://git.reviewboard.kde.org/r/119432/#comment43739>

    Laurent is right, definitely not binary compatible.
    https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++#The_Do.27s_and_Don.27ts says "If you need to add extend/modify the parameter list of an existing function, you need to add a new function instead with the new parameters. In that case, you may want to add a short note that the two functions shall be merged with a default argument in later versions of the library"



akonadi/calendar/itiphandler.h
<https://git.reviewboard.kde.org/r/119432/#comment43740>

    style nitpick: no space after identity.
    Also: maybe pass the parent last, with 0 as default value?



akonadi/calendar/itiphandler.cpp
<https://git.reviewboard.kde.org/r/119432/#comment43741>

    just a nitpick, but maybe use Q_UNUSED instead of commenting the arguments?



akonadi/calendar/mailclient_p.h
<https://git.reviewboard.kde.org/r/119432/#comment43743>

    BC consideration should not be problematic here, that looks like a private header (_p.h)



akonadi/calendar/mailclient_p.h
<https://git.reviewboard.kde.org/r/119432/#comment43742>

    do you need both factories? the one passed to the ctor and this one?



akonadi/calendar/tests/itiphandlertest.cpp
<https://git.reviewboard.kde.org/r/119432/#comment43744>

    style nitpick: intentaion of initialization list, spaces around :



akonadi/calendar/tests/itiphandlertest.cpp
<https://git.reviewboard.kde.org/r/119432/#comment43745>

    style nitpick: spaces around :



akonadi/calendar/tests/itiphandlertest.cpp
<https://git.reviewboard.kde.org/r/119432/#comment43746>

    don't need that if it is empty



akonadi/calendar/tests/mailclienttest.cpp
<https://git.reviewboard.kde.org/r/119432/#comment43747>

    spaces around :



akonadi/calendar/tests/mailclienttest.cpp
<https://git.reviewboard.kde.org/r/119432/#comment43748>

    see style comment on other class



akonadi/calendar/tests/mailclienttest.cpp
<https://git.reviewboard.kde.org/r/119432/#comment43749>

    see comment on other class


- Kevin Krammer


On Juli 23, 2014, 8:46 nachm., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119432/
> -----------------------------------------------------------
> 
> (Updated Juli 23, 2014, 8:46 nachm.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> To be able to customize the emails per attendee from an iTip event, we must be able to intercept the actually Job, that creates and sends the mail 
> 
> 
> Diffs
> -----
> 
>   akonadi/calendar/incidencechanger.h 858e487482f456541c4640a3b49e6dd4d5060b0f 
>   akonadi/calendar/incidencechanger.cpp aafa8d5158c29ddd92502ef86c49abaab514e52e 
>   akonadi/calendar/incidencechanger_p.h 82bdfa1d424fb847509828a04cf7ff3194dca507 
>   akonadi/calendar/itiphandler.h 5c581e7200f30efc69124e17306e9498a7e7589e 
>   akonadi/calendar/itiphandler.cpp 2b721999a7219e5dc5cf51b944fa75e502eafb17 
>   akonadi/calendar/itiphandler_p.h 35e895a54ea16ba2708ce0fe9632758f754d612c 
>   akonadi/calendar/itiphandler_p.cpp e62b72bf4bfb041c24598774fe028dbee0d7984d 
>   akonadi/calendar/itiphandlerhelper_p.h 11bc6de05cba8a17d55aba4a0f5514a3aafdac35 
>   akonadi/calendar/itiphandlerhelper_p.cpp ee3b68a0eeff66255069033ea722b3f327dad65a 
>   akonadi/calendar/mailclient_p.h c284806082d3d0fd22f94d5f2265d92ac0810fd6 
>   akonadi/calendar/mailclient_p.cpp 94acccefdb68bb986fd4f075b514521dc55d034b 
>   akonadi/calendar/mailscheduler_p.h cdbdd870f9c2c12751fbe7c6c6de1842a858aa33 
>   akonadi/calendar/mailscheduler_p.cpp cfeebd03afb212a18714d92fc1d9044050a971d4 
>   akonadi/calendar/tests/itiphandlertest.cpp f1167e151057113d88233306527d21e7ea9e64c2 
>   akonadi/calendar/tests/mailclienttest.cpp 8235b31c7f3540c32df92e65d37f990a24c776ea 
> 
> Diff: https://git.reviewboard.kde.org/r/119432/diff/
> 
> 
> Testing
> -------
> 
> run multiple times kincidenceeditor and korganizer to test and run itiphelpertest and mailclienttest.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/