[Kde-pim] Review Request 119491: CollectionSync: split sync transaction into multiple smaller transactions

[Christian Mollekopf]

> On July 26, 2014, 6:25 p.m., Christian Mollekopf wrote:
> > Ship It!

As noted in the other review request, I get much worse performance compared to yours, but that may be due to the testmachine/setup. It's also here an improvement compared to before though, so the patch is ok for me.
Perhaps check again regarding the memory consumption you found in the LIST patch if this isn't related to this patch (I can't reproduce them).
But IMO we can commit this anyways, we'll just have to figure out what's the problem at some point.


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119491/#review63229
-----------------------------------------------------------


On July 26, 2014, 4:13 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119491/
> -----------------------------------------------------------
> 
> (Updated July 26, 2014, 4:13 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Christian Mollekopf.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> As it turned out creating a large amount of collections via CollectionSync is extremely slow when it all happens within one TransactionSequence, because for the Server it means a single database transaction. And appending thousands of INSERTs into the transaction journal is rather slow with all database backends we support.
> 
> This patch just commits the TransactionSequence after every 100 collections, which results in a huuuge performance improvement (CollectionSync with 100k collections wnt down from ~20 minutes to ~1 minute).
> 
> 
> Diffs
> -----
> 
>   akonadi/collectionsync.cpp 1a9f760 
> 
> Diff: https://git.reviewboard.kde.org/r/119491/diff/
> 
> 
> Testing
> -------
> 
> collectionsynctest still passes
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/