[Kde-pim] Review Request 119434: Per attendee customization of email [2] - DialogInterception for IncienceChanger

[Kevin Krammer]

> On Juli 24, 2014, 10:03 vorm., Kevin Krammer wrote:
> > akonadi/calendar/itiphandler.h, line 70
> > <https://git.reviewboard.kde.org/r/119434/diff/1/?file=292206#file292206line70>
> >
> >     no explicit needed, there are three required arguments.
> >     parent should probably be last, with 0 as default?
> 
> Sandro Knauß wrote:
>     Can you explain this further ?hy here is no explicit needed?

a constructor that can be called with just one argument can be used by the compiler for implicit/automatic type conversion.
Like QString(const char*), which allows converstion of a string literal into a QString, e.g. when calling setText(const QString &) like that: setText("foo")

The explicit keyword disallows this kind of use of constructor, usually when the single argument is not the content but something else, like a qobject parent.

In this case the constructor requires 3 arguments, it cannot be selected for type conversion


> On Juli 24, 2014, 10:03 vorm., Kevin Krammer wrote:
> > akonadi/calendar/itiphandler.h, line 124
> > <https://git.reviewboard.kde.org/r/119434/diff/1/?file=292206#file292206line124>
> >
> >     this is a new class, right? I.e. it has not been part of a release yet?
> 
> Sandro Knauß wrote:
>     Yep it is a new class

Ok, just wanted to be safe. Adding a new virtual is a binary incompatible change, so only OK as long as this class has not been part of the public API yet


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119434/#review63036
-----------------------------------------------------------


On Juli 24, 2014, 1:39 nachm., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119434/
> -----------------------------------------------------------
> 
> (Updated Juli 24, 2014, 1:39 nachm.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> To be able to customize the emails per attendee from an iTip event. The dialogs opened by IncidenceChange has to be interceptable. You can see the both changeset in the dev/individual_mail2 branch.
> 
> 
> Diffs
> -----
> 
>   akonadi/calendar/incidencechanger.cpp aafa8d5158c29ddd92502ef86c49abaab514e52e 
>   akonadi/calendar/incidencechanger_p.h 82bdfa1d424fb847509828a04cf7ff3194dca507 
>   akonadi/calendar/itiphandler.h 5c581e7200f30efc69124e17306e9498a7e7589e 
>   akonadi/calendar/itiphandler.cpp 2b721999a7219e5dc5cf51b944fa75e502eafb17 
>   akonadi/calendar/itiphandler_p.h 35e895a54ea16ba2708ce0fe9632758f754d612c 
>   akonadi/calendar/itiphandler_p.cpp e62b72bf4bfb041c24598774fe028dbee0d7984d 
>   akonadi/calendar/itiphandlerhelper_p.h 11bc6de05cba8a17d55aba4a0f5514a3aafdac35 
>   akonadi/calendar/itiphandlerhelper_p.cpp ee3b68a0eeff66255069033ea722b3f327dad65a 
> 
> Diff: https://git.reviewboard.kde.org/r/119434/diff/
> 
> 
> Testing
> -------
> 
> run multiple times kincidenceeditor and korganizer to test and run itiphelpertest and mailclienttest.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/