[Kde-pim] Review Request 119433: Use fullName instead of own building the same logic
Kevin Krammer
krammer at kde.org
Thu Jul 24 09:46:49 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119433/#review63034
-----------------------------------------------------------
looks good to me, Person::fullName() seems to be doing what the old code had done.
- Kevin Krammer
On Juli 23, 2014, 8:38 nachm., Sandro Knauß wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119433/
> -----------------------------------------------------------
>
> (Updated Juli 23, 2014, 8:38 nachm.)
>
>
> Review request for KDEPIM-Libraries.
>
>
> Repository: kdepimlibs
>
>
> Description
> -------
>
> KCalCore::Attendee has a method to create the fullName like this, su we should use tis method
>
>
> Diffs
> -----
>
> akonadi/calendar/mailclient_p.cpp 2345007b6dac8715f0f10d8a531a65fb98b9cfe5
>
> Diff: https://git.reviewboard.kde.org/r/119433/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sandro Knauß
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list