[Kde-pim] Review Request 119474: Coding Style for agentinstance.cpp agentmanager.cpp agentmanager.h agentprocessinstance.cpp agentprocessinstance.h agentthreadinstance.cpp agentthreadinstance.h agenttype.cpp agenttype.h controlmanager.cpp controlmanager.h main.cpp processcontrol.cpp processcontrol.h

[Kevin Krammer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119474/#review63253
-----------------------------------------------------------



server/control/agentmanager.cpp
<https://git.reviewboard.kde.org/r/119474/#comment44025>

    no space after &



server/control/agentmanager.cpp
<https://git.reviewboard.kde.org/r/119474/#comment44026>

    no space after &



server/control/agentmanager.cpp
<https://git.reviewboard.kde.org/r/119474/#comment44027>

    no space after &



server/control/agentmanager.cpp
<https://git.reviewboard.kde.org/r/119474/#comment44028>

    no space after &



server/control/agentmanager.cpp
<https://git.reviewboard.kde.org/r/119474/#comment44029>

    no space after &



server/control/agentmanager.cpp
<https://git.reviewboard.kde.org/r/119474/#comment44030>

    no space after &



server/control/agentmanager.cpp
<https://git.reviewboard.kde.org/r/119474/#comment44031>

    no space after &



server/control/agentmanager.cpp
<https://git.reviewboard.kde.org/r/119474/#comment44032>

    no space after &



server/control/agentmanager.cpp
<https://git.reviewboard.kde.org/r/119474/#comment44033>

    no space after &



server/control/agentmanager.cpp
<https://git.reviewboard.kde.org/r/119474/#comment44034>

    hmm, shouldn't this be on the previous line?



server/control/agentmanager.cpp
<https://git.reviewboard.kde.org/r/119474/#comment44035>

    shouldn't the closing brace have the same intentation as case?



server/control/agentmanager.cpp
<https://git.reviewboard.kde.org/r/119474/#comment44037>

    no space after &



server/control/agentmanager.cpp
<https://git.reviewboard.kde.org/r/119474/#comment44038>

    no space after &



server/control/agentmanager.cpp
<https://git.reviewboard.kde.org/r/119474/#comment44039>

    no space after &



server/control/agenttype.cpp
<https://git.reviewboard.kde.org/r/119474/#comment44040>

    no space after &



server/control/agenttype.cpp
<https://git.reviewboard.kde.org/r/119474/#comment44041>

    no space after &



server/control/processcontrol.cpp
<https://git.reviewboard.kde.org/r/119474/#comment44042>

    no space after &


- Kevin Krammer


On Juli 25, 2014, 5:14 nachm., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119474/
> -----------------------------------------------------------
> 
> (Updated Juli 25, 2014, 5:14 nachm.)
> 
> 
> Review request for Akonadi and Dan Vrátil.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> This is the second run.
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   server/control/agenttype.cpp 02589ca 
>   server/control/controlmanager.h ba050a0 
>   server/control/controlmanager.cpp 483ebe4 
>   server/control/main.cpp e725591 
>   server/control/processcontrol.h 2df98e5 
>   server/control/processcontrol.cpp 52f9b4a 
>   server/control/agentinstance.cpp 07ae9ff 
>   server/control/agentmanager.h a0c1df5 
>   server/control/agentmanager.cpp ab38357 
>   server/control/agentprocessinstance.h 00dae8b 
>   server/control/agentprocessinstance.cpp d15fe6b 
>   server/control/agentthreadinstance.h 54b7df9 
>   server/control/agentthreadinstance.cpp aa75f3e 
>   server/control/agenttype.h b9ad8b4 
> 
> Diff: https://git.reviewboard.kde.org/r/119474/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/