[Kde-pim] Review Request 119434: Per attendee customization of email [2] - DialogInterception for IncienceChanger

[Sandro Knauß]

> On Juli 24, 2014, 2:05 nachm., Kevin Krammer wrote:
> > akonadi/calendar/itiphandler.h, line 83
> > <https://git.reviewboard.kde.org/r/119434/diff/1-2/?file=292206#file292206line83>
> >
> >     the argument should probably also be called like the enum.
> >     what about moving it to the last position so it can get a default? or is this overload specifially intended to force a choice?
> 
> Sandro Knauß wrote:
>     I think it is worth to have a same parameter scheme for all functions and not to change the order for one of them. Maybe use the same defaults for askUserIfNeeded or we can move it to protected, so child classes can use it. The method askUserIfNeeded is never called directly.
> 
> Kevin Krammer wrote:
>     Right, I was assuming it could be moved for the others as well.
>     I think my main problem is that I don't really get why this argument is needed? Why not just pass the action and get rid of default action?

Actullay I don't have strong arguments for the ignoreDefaultAction. I only copied the logic out from ITIPHandlerHelper and this classes has a default action.
But because the AskDelegator object is only a short living object only for one dialog, it is fair enough to get rid of this and use Action as parameter.


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119434/#review63066
-----------------------------------------------------------


On Juli 24, 2014, 7:52 nachm., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119434/
> -----------------------------------------------------------
> 
> (Updated Juli 24, 2014, 7:52 nachm.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> To be able to customize the emails per attendee from an iTip event. The dialogs opened by IncidenceChange has to be interceptable. You can see the both changeset in the dev/individual_mail2 branch.
> 
> 
> Diffs
> -----
> 
>   akonadi/calendar/itiphandler.cpp 2b721999a7219e5dc5cf51b944fa75e502eafb17 
>   akonadi/calendar/itiphandler_p.h 35e895a54ea16ba2708ce0fe9632758f754d612c 
>   akonadi/calendar/itiphandler_p.cpp e62b72bf4bfb041c24598774fe028dbee0d7984d 
>   akonadi/calendar/itiphandlerhelper_p.h 11bc6de05cba8a17d55aba4a0f5514a3aafdac35 
>   akonadi/calendar/itiphandlerhelper_p.cpp ee3b68a0eeff66255069033ea722b3f327dad65a 
>   akonadi/calendar/incidencechanger.cpp aafa8d5158c29ddd92502ef86c49abaab514e52e 
>   akonadi/calendar/incidencechanger_p.h 82bdfa1d424fb847509828a04cf7ff3194dca507 
>   akonadi/calendar/incidencechanger_p.cpp 74cf138a87564e2dc4d1a8e49d45fe5ac620e2e6 
>   akonadi/calendar/itiphandler.h 5c581e7200f30efc69124e17306e9498a7e7589e 
> 
> Diff: https://git.reviewboard.kde.org/r/119434/diff/
> 
> 
> Testing
> -------
> 
> run multiple times kincidenceeditor and korganizer to test and run itiphelpertest and mailclienttest.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/