[Kde-pim] Review Request 119390: Coding Style for blockalarmsattribute.h calendarbase.h calendarbase_p.h calendarmodel_p.h calfilterproxymodel_p.h

[Sergio Luis Martins]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119390/#review62820
-----------------------------------------------------------



akonadi-calendar/src/calendarbase.h
<https://git.reviewboard.kde.org/r/119390/#comment43566>

    No point in having "incidence" 3 times, it's aleady explicit in the type and method name


- Sergio Luis Martins


On July 21, 2014, 5:52 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119390/
> -----------------------------------------------------------
> 
> (Updated July 21, 2014, 5:52 p.m.)
> 
> 
> Review request for KDEPIM-Libraries and Kevin Krammer.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> This is the second run.
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   akonadi-calendar/src/blockalarmsattribute.h fb10838 
>   akonadi-calendar/src/calendarbase.h 4082d41 
>   akonadi-calendar/src/calendarbase_p.h 87bec31 
>   akonadi-calendar/src/calendarmodel_p.h 8727488 
>   akonadi-calendar/src/calfilterproxymodel_p.h ba83ff5 
> 
> Diff: https://git.reviewboard.kde.org/r/119390/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/