[Kde-pim] Review Request 119432: Per attendee customization of email [1] - Make MailClient interceptable

[Sandro Knauß]

> On Juli 24, 2014, 5:20 vorm., Laurent Montel wrote:
> > akonadi/calendar/mailclient_p.h, line 76
> > <https://git.reviewboard.kde.org/r/119432/diff/1/?file=292197#file292197line76>
> >
> >     For each function that you add a new argument, is it BC ?

The MailClient is only exported, when running unittest - see PLEASE_TEST_INVITATIONS switch. So it should be ok to change the API.


> On Juli 24, 2014, 5:20 vorm., Laurent Montel wrote:
> > akonadi/calendar/mailclient_p.h, line 129
> > <https://git.reviewboard.kde.org/r/119432/diff/1/?file=292197#file292197line129>
> >
> >     you remove a public static variable ?

This viariable was used for unittests, we now can use the MessageQueueJobFactory to intercept the mails. That made the code cleaner in mailclient and no different path for unittests.

The logic for unittess is moved to tests/mailclienttest.cpp see class FakeMessageQueueJob.


- Sandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119432/#review63026
-----------------------------------------------------------


On Juli 24, 2014, 1:54 nachm., Sandro Knauß wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119432/
> -----------------------------------------------------------
> 
> (Updated Juli 24, 2014, 1:54 nachm.)
> 
> 
> Review request for KDEPIM-Libraries.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> To be able to customize the emails per attendee from an iTip event, we must be able to intercept the actually Job, that creates and sends the mail 
> 
> 
> Diffs
> -----
> 
>   akonadi/calendar/freebusymanager.cpp bf64dab3275a1445e19b7032f8e4d34fe0a0e75e 
>   akonadi/calendar/history.h 45e981f548df6570576e9d68ac9ac1e88a124dac 
>   akonadi/calendar/history.cpp 4d18208d47d034b8151fc0f499f5cc43b2935903 
>   akonadi/calendar/incidencechanger.h 858e487482f456541c4640a3b49e6dd4d5060b0f 
>   akonadi/calendar/incidencechanger.cpp aafa8d5158c29ddd92502ef86c49abaab514e52e 
>   akonadi/calendar/incidencechanger_p.h 82bdfa1d424fb847509828a04cf7ff3194dca507 
>   akonadi/calendar/itiphandler.h 5c581e7200f30efc69124e17306e9498a7e7589e 
>   akonadi/calendar/itiphandler.cpp 2b721999a7219e5dc5cf51b944fa75e502eafb17 
>   akonadi/calendar/itiphandler_p.h 35e895a54ea16ba2708ce0fe9632758f754d612c 
>   akonadi/calendar/itiphandler_p.cpp e62b72bf4bfb041c24598774fe028dbee0d7984d 
>   akonadi/calendar/itiphandlerhelper_p.h 11bc6de05cba8a17d55aba4a0f5514a3aafdac35 
>   akonadi/calendar/itiphandlerhelper_p.cpp ee3b68a0eeff66255069033ea722b3f327dad65a 
>   akonadi/calendar/mailclient_p.h c284806082d3d0fd22f94d5f2265d92ac0810fd6 
>   akonadi/calendar/mailclient_p.cpp 94acccefdb68bb986fd4f075b514521dc55d034b 
>   akonadi/calendar/mailscheduler_p.h cdbdd870f9c2c12751fbe7c6c6de1842a858aa33 
>   akonadi/calendar/mailscheduler_p.cpp cfeebd03afb212a18714d92fc1d9044050a971d4 
>   akonadi/calendar/tests/CMakeLists.txt 382e3ec81e189085e4fbf9f34a3be9e6511e52f7 
>   akonadi/calendar/tests/itiphandlertest.cpp f1167e151057113d88233306527d21e7ea9e64c2 
>   akonadi/calendar/tests/mailclienttest.cpp 8235b31c7f3540c32df92e65d37f990a24c776ea 
>   akonadi/calendar/tests/unittestbase.cpp 756a731035f07d52f511e0e0edef79e4feeee6b6 
> 
> Diff: https://git.reviewboard.kde.org/r/119432/diff/
> 
> 
> Testing
> -------
> 
> run multiple times kincidenceeditor and korganizer to test and run itiphelpertest and mailclienttest.
> 
> 
> Thanks,
> 
> Sandro Knauß
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/