[Kde-pim] Review Request 119298: IMAP Resource: let an instance of Settings be owned by ImapResource, instead of being a singleton

[Christian Mollekopf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119298/#review62491
-----------------------------------------------------------

Ship it!


Ship It!

- Christian Mollekopf


On July 15, 2014, noon, Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119298/
> -----------------------------------------------------------
> 
> (Updated July 15, 2014, noon)
> 
> 
> Review request for KDEPIM and Christian Mollekopf.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> I need to reimplement some things from Imap's Settings in GmailSettings. Since IMAP's Settings is a singleton, it's hard to do it. This patch removes singleton from Settings and instead makes Settings instance to be owned by ImapResourceBase and available via virtual ImapResourceBase::settings() const method, which can be overriden in GmailResource to return instance of GmailSettings instead.
> 
> This is necessary first step for proper fix of bug 336758.
> 
> 
> Diffs
> -----
> 
>   resources/imap/resourcestate.cpp ef1111a 
>   resources/imap/settings.h de77d20 
>   resources/imap/settings.cpp 69d8022 
>   resources/imap/settingspasswordrequester.cpp a4778e2 
>   resources/imap/setupserver.cpp c77e41f 
>   resources/imap/imapresource.cpp 779f713 
>   resources/imap/imapresourcebase.h bc80ec5 
>   resources/imap/imapresourcebase.cpp fabe7e6 
> 
> Diff: https://git.reviewboard.kde.org/r/119298/diff/
> 
> 
> Testing
> -------
> 
> IMAP and Kolab resources still work.
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/