[Kde-pim] Review Request 119476: Coding Style for akonadi.cpp cachecleaner.cpp clientcapabilities.cpp clientcapabilityaggregator.cpp collectionreferencemanager.cpp collectionscheduler.cpp commandcontext.cpp connection.cpp connectionthread.cpp dbusconnectionpool.cpp dbustracer.cpp debuginterface.cpp filetracer.cpp handler.

Sun Jul 27 17:57:05 BST 2014

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119476/#review63278
-----------------------------------------------------------


server/src/collectionscheduler.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44062>

    no space after &


server/src/collectionscheduler.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44063>

    no space after &


server/src/collectionscheduler.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44064>

    no space after &


server/src/handlerhelper.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44065>

    no space after &


server/src/handlerhelper.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44066>

    no space after &


server/src/handlerhelper.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44067>

    no space after &


server/src/handlerhelper.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44068>

    no space after &


server/src/handlerhelper.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44069>

    no space after &


server/src/nepomuksearch.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44072>

    no space after &


server/src/nepomuksearch.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44073>

    no space after &


server/src/nepomuksearch.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44074>

    no space after &


server/src/notificationmanager.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44075>

    no space after &


server/src/notificationmanager.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44076>

    no space after &


server/src/notificationmanager.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44077>

    no space after &


server/src/notificationmanager.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44078>

    no space after *


server/src/notificationmanager.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44079>

    no space after *


server/src/notificationmanager.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44080>

    no space after &


server/src/notificationmanager.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44081>

    no space after *


server/src/notificationsource.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44082>

    no space after &


server/src/notificationsource.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44083>

    no space after &


server/src/notificationsource.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44084>

    no space after &


server/src/notificationsource.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44085>

    no space after &


server/src/notificationsource.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44086>

    no space after &


server/src/preprocessormanager.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44087>

    no space after *


server/src/resourcemanager.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44088>

    no space after &


server/src/storagejanitor.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44089>

    no space after &


server/src/storagejanitor.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44090>

    no space after &


server/src/storagejanitor.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44091>

    no space after &


server/src/storagejanitor.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44092>

    no space after &


server/src/storagejanitor.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44093>

    no space after &


server/src/storagejanitor.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44094>

    no space after &


server/src/storagejanitor.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44095>

    no space after &


server/src/storagejanitor.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44096>

    no space after &


server/src/storagejanitor.cpp
<https://git.reviewboard.kde.org/r/119476/#comment44097>

    no space after &


- Kevin Krammer


On Juli 26, 2014, 8:12 vorm., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119476/
> -----------------------------------------------------------
> 
> (Updated Juli 26, 2014, 8:12 vorm.)
> 
> 
> Review request for Akonadi and Dan Vrátil.
> 
> 
> Repository: akonadi
> 
> 
> Description
> -------
> 
> This is the second run.
> Details can be seen at:
>   http://techbase.kde.org/Policies/Kdepim_Coding_Style
> 
> 
> Diffs
> -----
> 
>   server/src/main.cpp 030241a 
>   server/src/nepomuksearch.cpp 19d56a4 
>   server/src/notificationmanager.cpp ba222bb 
>   server/src/notificationsource.cpp c190e31 
>   server/src/preprocessorinstance.cpp e087ab0 
>   server/src/preprocessormanager.cpp 9d8df35 
>   server/src/resourcemanager.cpp e7c14f8 
>   server/src/response.cpp 07a4276 
>   server/src/storagejanitor.cpp effbbf7 
>   server/src/tracer.cpp 307a187 
>   server/src/utils.cpp b04a812 
>   server/src/handlerhelper.cpp 634a26c 
>   server/src/imapstreamparser.cpp 425b7b7 
>   server/src/intervalcheck.cpp 34d70b0 
>   server/src/filetracer.cpp 5a89478 
>   server/src/handler.cpp 7e95067 
>   server/src/dbusconnectionpool.cpp 9aede4f 
>   server/src/dbustracer.cpp 891100e 
>   server/src/debuginterface.cpp 2be1fa6 
>   server/src/akonadi.cpp 5369320 
>   server/src/cachecleaner.cpp fbdf9d0 
>   server/src/clientcapabilities.cpp a504b9c 
>   server/src/clientcapabilityaggregator.cpp 5dd69cb 
>   server/src/collectionreferencemanager.cpp 0160ef3 
>   server/src/collectionscheduler.cpp 2c99c55 
>   server/src/commandcontext.cpp f964c0a 
>   server/src/connection.cpp 32f10d5 
>   server/src/connectionthread.cpp 3596851 
> 
> Diff: https://git.reviewboard.kde.org/r/119476/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/